test: execute _test.mjs even if executeOutput is false (#8398)

sapphi-red · sapphi-red · commit 5e11c772b51b · 2026-02-20T12:06:46.000Z
The behavior was not aligned with this comment: https://github.com/rolldown/rolldown/blob/f94dbcc68e79244542bac01d6cb13aa46e004738/crates/rolldown_testing_config/src/test_meta.rs#L11
diff --git a/crates/rolldown/tests/rolldown/function/dir/should_generate_correct_relative_import_path/_test.mjs b/crates/rolldown/tests/rolldown/function/dir/should_generate_correct_relative_import_path/_test.mjs
@@ -1,6 +1,6 @@
 import assert from 'node:assert';
-import { value, asyncValue } from './dist/lib/entries/a.js';
-import { value as value2, asyncValue as asyncValue2 } from './dist/lib/entries/b.js';
+import { value, asyncValue } from './dist/lib/entries/a.mjs';
+import { value as value2, asyncValue as asyncValue2 } from './dist/lib/entries/b.mjs';
 
 assert.strictEqual(value, value2);
 assert.strictEqual(await asyncValue, await asyncValue2);
diff --git a/crates/rolldown/tests/rolldown/function/entry_filenames/should_generate_correct_relative_import_path/_test.mjs b/crates/rolldown/tests/rolldown/function/entry_filenames/should_generate_correct_relative_import_path/_test.mjs
@@ -1,6 +1,6 @@
 import assert from 'node:assert';
-import { value, asyncValue } from './dist/entries/a.js';
-import { value as value2, asyncValue as asyncValue2 } from './dist/entries/b.js';
+import { value, asyncValue } from './dist/entries/a.mjs';
+import { value as value2, asyncValue as asyncValue2 } from './dist/entries/b.mjs';
 
 assert.strictEqual(value, value2);
 assert.strictEqual(await asyncValue, await asyncValue2);
diff --git a/crates/rolldown/tests/rolldown/misc/preserve_modules/issue_4944/_test.mjs b/crates/rolldown/tests/rolldown/misc/preserve_modules/issue_4944/_test.mjs
@@ -1,4 +1,4 @@
-import { assert } from 'node:test';
+import assert from 'node:assert';
 import { b } from './dist/a/index.js';
 
 assert.strictEqual(b, 2, 'b should be 2');
diff --git a/crates/rolldown/tests/rolldown/sourcemap/debug_ids/_test.mjs b/crates/rolldown/tests/rolldown/sourcemap/debug_ids/_test.mjs
@@ -1,15 +1,14 @@
-const require = (await import('node:module')).createRequire(import.meta.url);
-const fs = require('node:fs');
-const assert = require('node:assert');
-const path = require('node:path');
+import fs from 'node:fs';
+import assert from 'node:assert';
+import path from 'node:path';
 
-const source = fs.readFileSync(path.resolve(__dirname, 'dist/assets/main.js'), 'utf8');
+const source = fs.readFileSync(path.resolve(import.meta.dirname, 'dist/assets/main.js'), 'utf8');
 const match = source.match(/\/\/# debugId=([a-fA-F0-9-]+)/);
 
 assert.ok(match, 'Could not find debugId in source');
 const sourceDebugId = match[1];
 
 const sourceMap = JSON.parse(
-  fs.readFileSync(path.resolve(__dirname, 'dist/assets/main.js.map'), 'utf8'),
+  fs.readFileSync(path.resolve(import.meta.dirname, 'dist/assets/main.js.map'), 'utf8'),
 );
 assert.equal(sourceMap.debugId, sourceDebugId, 'debugId mismatch');
diff --git a/crates/rolldown_testing/src/integration_test.rs b/crates/rolldown_testing/src/integration_test.rs
@@ -324,20 +324,33 @@ impl IntegrationTest {
 
           // Execute output if needed
           let bundler_options = dev_engine.bundler_options().await;
+          let config_name = named_options
+            .config_name
+            .as_deref()
+            .map(Some)
+            .unwrap_or(self.test_meta.config_name.as_deref());
           if self.should_execute_output() {
             Self::execute_output_assets(
               &bundler_options,
               &debug_title,
               &patch_chunks,
-              named_options
-                .config_name
-                .as_deref()
-                .map(Some)
-                .unwrap_or(self.test_meta.config_name.as_deref()),
+              config_name,
+              true,
             );
-          } else if !self.test_meta.skip_syntax_validation {
-            // When not executing output, validate that all JS chunks are syntactically valid
-            Self::validate_output_chunks_syntax(output, &bundler_options);
+          } else {
+            if self.test_meta.write_to_disk {
+              Self::execute_output_assets(
+                &bundler_options,
+                &debug_title,
+                &patch_chunks,
+                config_name,
+                false,
+              );
+            }
+            if !self.test_meta.skip_syntax_validation {
+              // When not executing output, validate that all JS chunks are syntactically valid
+              Self::validate_output_chunks_syntax(output, &bundler_options);
+            }
           }
         }
         Err(errs) => {
@@ -414,20 +427,21 @@ impl IntegrationTest {
             !self.test_meta.expect_error,
             "Expected the bundling to be failed with diagnosable errors, but got success"
           );
+          let config_name = named_options
+            .config_name
+            .as_deref()
+            .map(Some)
+            .unwrap_or(self.test_meta.config_name.as_deref());
           if self.should_execute_output() {
-            Self::execute_output_assets(
-              bundler.options(),
-              &debug_title,
-              &[],
-              named_options
-                .config_name
-                .as_deref()
-                .map(Some)
-                .unwrap_or(self.test_meta.config_name.as_deref()),
-            );
-          } else if !self.test_meta.skip_syntax_validation {
-            // When not executing output, validate that all JS chunks are syntactically valid
-            Self::validate_output_chunks_syntax(output, bundler.options());
+            Self::execute_output_assets(bundler.options(), &debug_title, &[], config_name, true);
+          } else {
+            if self.test_meta.write_to_disk {
+              Self::execute_output_assets(bundler.options(), &debug_title, &[], config_name, false);
+            }
+            if !self.test_meta.skip_syntax_validation {
+              // When not executing output, validate that all JS chunks are syntactically valid
+              Self::validate_output_chunks_syntax(output, bundler.options());
+            }
           }
         }
         Err(errs) => {
@@ -554,6 +568,7 @@ impl IntegrationTest {
     test_title: &str,
     patch_chunks: &[String],
     config_name: Option<&str>,
+    execute_compiled_entries: bool,
   ) {
     let cwd = options.cwd.clone();
     let dist_folder = cwd.join(&options.out_dir);
@@ -597,6 +612,8 @@ impl IntegrationTest {
 
     if test_script.exists() {
       node_command.arg(test_script);
+    } else if !execute_compiled_entries {
+      return;
     } else {
       // make sure to set this: https://github.com/nodejs/node/issues/59374
       node_command.arg("--input-type=module");
