feat(dev): add binding for DevOptions#rebuild_strategy (#6396)

hyf0 · hyf0 · commit 1ae7f074bc09 · 2025-10-02T10:32:39.000Z
diff --git a/crates/rolldown_binding/src/binding_dev_engine.rs b/crates/rolldown_binding/src/binding_dev_engine.rs
@@ -31,6 +31,8 @@ impl BindingDevEngine {
     let session = rolldown_debug::Session::dummy();
 
     let on_hmr_updates_callback = dev_options.as_ref().and_then(|opts| opts.on_hmr_updates.clone());
+    let rebuild_strategy =
+      dev_options.as_ref().and_then(|opts| opts.rebuild_strategy).map(Into::into);
     let watch_options = dev_options.as_ref().and_then(|opts| opts.watch.as_ref());
     let skip_write = watch_options.and_then(|watch| watch.skip_write);
     let use_polling = watch_options.and_then(|watch| watch.use_polling);
@@ -78,8 +80,8 @@ impl BindingDevEngine {
     let rolldown_dev_options = rolldown::dev::dev_options::DevOptions {
       on_hmr_updates,
       on_output: None, // Rust-only for now
+      rebuild_strategy,
       watch: dev_watch_options,
-      ..Default::default()
     };
 
     let inner = rolldown::DevEngine::with_bundler(bundler, rolldown_dev_options)
diff --git a/crates/rolldown_binding/src/binding_dev_options.rs b/crates/rolldown_binding/src/binding_dev_options.rs
@@ -1,4 +1,5 @@
 use crate::types::binding_hmr_output::BindingClientHmrUpdate;
+use crate::types::binding_rebuild_strategy::BindingRebuildStrategy;
 use crate::types::js_callback::JsCallback;
 use napi::bindgen_prelude::FnArgs;
 use napi_derive::napi;
@@ -20,5 +21,6 @@ pub struct BindingDevOptions {
     ts_type = "undefined | ((updates: BindingClientHmrUpdate[], changedFiles: string[]) => void | Promise<void>)"
   )]
   pub on_hmr_updates: Option<JsCallback<FnArgs<(Vec<BindingClientHmrUpdate>, Vec<String>)>, ()>>,
+  pub rebuild_strategy: Option<BindingRebuildStrategy>,
   pub watch: Option<BindingDevWatchOptions>,
 }
diff --git a/crates/rolldown_binding/src/types/binding_rebuild_strategy.rs b/crates/rolldown_binding/src/types/binding_rebuild_strategy.rs
@@ -0,0 +1,20 @@
+use napi_derive::napi;
+
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
+#[napi]
+pub enum BindingRebuildStrategy {
+  Always,
+  Auto,
+  #[default]
+  Never,
+}
+
+impl From<BindingRebuildStrategy> for rolldown::dev::RebuildStrategy {
+  fn from(value: BindingRebuildStrategy) -> Self {
+    match value {
+      BindingRebuildStrategy::Always => Self::Always,
+      BindingRebuildStrategy::Auto => Self::Auto,
+      BindingRebuildStrategy::Never => Self::Never,
+    }
+  }
+}
diff --git a/crates/rolldown_binding/src/types/mod.rs b/crates/rolldown_binding/src/types/mod.rs
@@ -7,6 +7,7 @@ pub mod binding_normalized_options;
 pub mod binding_output_asset;
 pub mod binding_output_chunk;
 pub mod binding_outputs;
+pub mod binding_rebuild_strategy;
 pub mod binding_rendered_chunk;
 pub mod binding_rendered_module;
 pub mod binding_resolve_alias_item;
diff --git a/packages/rolldown/src/api/dev/dev-engine.ts b/packages/rolldown/src/api/dev/dev-engine.ts
@@ -1,4 +1,8 @@
-import { type BindingClientHmrUpdate, BindingDevEngine } from '../../binding';
+import {
+  type BindingClientHmrUpdate,
+  BindingDevEngine,
+  BindingRebuildStrategy,
+} from '../../binding';
 import type { InputOptions } from '../../options/input-options';
 import type { OutputOptions } from '../../options/output-options';
 import { PluginDriver } from '../../plugin/plugin-driver';
@@ -23,6 +27,13 @@ export class DevEngine {
 
     const bindingDevOptions = {
       onHmrUpdates: devOptions.onHmrUpdates,
+      rebuildStrategy: devOptions.rebuildStrategy
+        ? devOptions.rebuildStrategy === 'always'
+          ? BindingRebuildStrategy.Always
+          : devOptions.rebuildStrategy === 'auto'
+          ? BindingRebuildStrategy.Auto
+          : BindingRebuildStrategy.Never
+        : undefined,
       watch: devOptions.watch && {
         skipWrite: devOptions.watch.skipWrite,
         usePolling: devOptions.watch.usePolling,
diff --git a/packages/rolldown/src/api/dev/dev-options.ts b/packages/rolldown/src/api/dev/dev-options.ts
@@ -46,5 +46,13 @@ export interface DevOptions {
     updates: BindingClientHmrUpdate[],
     changedFiles: string[],
   ) => void | Promise<void>;
+  /**
+   * Strategy for triggering rebuilds after HMR updates.
+   * - `'always'`: Always trigger a rebuild after HMR updates
+   * - `'auto'`: Trigger rebuild only if HMR updates contain full reload updates
+   * - `'never'`: Never trigger rebuild after HMR updates (default)
+   * @default 'never'
+   */
+  rebuildStrategy?: 'always' | 'auto' | 'never';
   watch?: DevWatchOptions;
 }
diff --git a/packages/rolldown/src/binding.d.ts b/packages/rolldown/src/binding.d.ts
@@ -1617,6 +1617,7 @@ export interface BindingDeferSyncScanData {
 
 export interface BindingDevOptions {
   onHmrUpdates?: undefined | ((updates: BindingClientHmrUpdate[], changedFiles: string[]) => void | Promise<void>)
+  rebuildStrategy?: BindingRebuildStrategy
   watch?: BindingDevWatchOptions
 }
 
@@ -2089,6 +2090,12 @@ export interface BindingReactRefreshWrapperPluginConfig {
   reactRefreshHost: string
 }
 
+export declare enum BindingRebuildStrategy {
+  Always = 0,
+  Auto = 1,
+  Never = 2
+}
+
 export interface BindingRenderBuiltUrlConfig {
   ssr: boolean
   type: 'asset' | 'public'
diff --git a/packages/rolldown/src/binding.js b/packages/rolldown/src/binding.js
@@ -557,7 +557,7 @@ if (!nativeBinding) {
   throw new Error(`Failed to load native binding`)
 }
 
-const { minify, Severity, ParseResult, ExportExportNameKind, ExportImportNameKind, ExportLocalNameKind, ImportNameKind, parseAsync, parseSync, rawTransferSupported, ResolverFactory, EnforceExtension, ModuleType, sync, HelperMode, isolatedDeclaration, moduleRunnerTransform, transform, transformAsync, BindingBundleEndEventData, BindingBundleErrorEventData, BindingBundler, BindingBundlerImpl, BindingCallableBuiltinPlugin, BindingChunkingContext, BindingClientHmrUpdate, BindingDevEngine, BindingHmrOutput, BindingMagicString, BindingModuleInfo, BindingNormalizedOptions, BindingOutputAsset, BindingOutputChunk, BindingOutputs, BindingPluginContext, BindingRenderedChunk, BindingRenderedChunkMeta, BindingRenderedModule, BindingTransformPluginContext, BindingWatcher, BindingWatcherChangeData, BindingWatcherEvent, ParallelJsPluginRegistry, ScheduledBuild, TraceSubscriberGuard, BindingAttachDebugInfo, BindingBuiltinPluginName, BindingChunkModuleOrderBy, BindingJsx, BindingLogLevel, BindingPluginOrder, BindingPropertyReadSideEffects, BindingPropertyWriteSideEffects, FilterTokenKind, initTraceSubscriber, registerPlugins, shutdownAsyncRuntime, startAsyncRuntime } = nativeBinding
+const { minify, Severity, ParseResult, ExportExportNameKind, ExportImportNameKind, ExportLocalNameKind, ImportNameKind, parseAsync, parseSync, rawTransferSupported, ResolverFactory, EnforceExtension, ModuleType, sync, HelperMode, isolatedDeclaration, moduleRunnerTransform, transform, transformAsync, BindingBundleEndEventData, BindingBundleErrorEventData, BindingBundler, BindingBundlerImpl, BindingCallableBuiltinPlugin, BindingChunkingContext, BindingClientHmrUpdate, BindingDevEngine, BindingHmrOutput, BindingMagicString, BindingModuleInfo, BindingNormalizedOptions, BindingOutputAsset, BindingOutputChunk, BindingOutputs, BindingPluginContext, BindingRenderedChunk, BindingRenderedChunkMeta, BindingRenderedModule, BindingTransformPluginContext, BindingWatcher, BindingWatcherChangeData, BindingWatcherEvent, ParallelJsPluginRegistry, ScheduledBuild, TraceSubscriberGuard, BindingAttachDebugInfo, BindingBuiltinPluginName, BindingChunkModuleOrderBy, BindingJsx, BindingLogLevel, BindingPluginOrder, BindingPropertyReadSideEffects, BindingPropertyWriteSideEffects, BindingRebuildStrategy, FilterTokenKind, initTraceSubscriber, registerPlugins, shutdownAsyncRuntime, startAsyncRuntime } = nativeBinding
 export { minify }
 export { Severity }
 export { ParseResult }
@@ -611,6 +611,7 @@ export { BindingLogLevel }
 export { BindingPluginOrder }
 export { BindingPropertyReadSideEffects }
 export { BindingPropertyWriteSideEffects }
+export { BindingRebuildStrategy }
 export { FilterTokenKind }
 export { initTraceSubscriber }
 export { registerPlugins }
diff --git a/packages/rolldown/src/experimental-index.ts b/packages/rolldown/src/experimental-index.ts
@@ -4,6 +4,7 @@ export type { DevOptions, DevWatchOptions } from './api/dev/dev-options';
 export { scan } from './api/experimental';
 export {
   BindingClientHmrUpdate,
+  BindingRebuildStrategy,
   isolatedDeclaration,
   type IsolatedDeclarationsOptions,
   type IsolatedDeclarationsResult,
diff --git a/packages/rolldown/src/rolldown-binding.wasi-browser.js b/packages/rolldown/src/rolldown-binding.wasi-browser.js
@@ -116,6 +116,7 @@ export const BindingLogLevel = __napiModule.exports.BindingLogLevel
 export const BindingPluginOrder = __napiModule.exports.BindingPluginOrder
 export const BindingPropertyReadSideEffects = __napiModule.exports.BindingPropertyReadSideEffects
 export const BindingPropertyWriteSideEffects = __napiModule.exports.BindingPropertyWriteSideEffects
+export const BindingRebuildStrategy = __napiModule.exports.BindingRebuildStrategy
 export const FilterTokenKind = __napiModule.exports.FilterTokenKind
 export const initTraceSubscriber = __napiModule.exports.initTraceSubscriber
 export const registerPlugins = __napiModule.exports.registerPlugins
diff --git a/packages/rolldown/src/rolldown-binding.wasi.cjs b/packages/rolldown/src/rolldown-binding.wasi.cjs
@@ -161,6 +161,7 @@ module.exports.BindingLogLevel = __napiModule.exports.BindingLogLevel
 module.exports.BindingPluginOrder = __napiModule.exports.BindingPluginOrder
 module.exports.BindingPropertyReadSideEffects = __napiModule.exports.BindingPropertyReadSideEffects
 module.exports.BindingPropertyWriteSideEffects = __napiModule.exports.BindingPropertyWriteSideEffects
+module.exports.BindingRebuildStrategy = __napiModule.exports.BindingRebuildStrategy
 module.exports.FilterTokenKind = __napiModule.exports.FilterTokenKind
 module.exports.initTraceSubscriber = __napiModule.exports.initTraceSubscriber
 module.exports.registerPlugins = __napiModule.exports.registerPlugins
