fix: throw fsevents stream start error properly#4
Merged
sapphi-red merged 1 commit intomainfrom Nov 13, 2025
Merged
Conversation
sapphi-red
deleted the
fix/throw-fsevents-stream-start-error-properly
branch
Merged
Boshen
added a commit
that referenced
this pull request
Nov 16, 2025
## 🤖 New release * `rolldown-notify-types`: 2.0.0 -> 2.0.1 (✓ API compatible changes) * `rolldown-notify`: 8.2.0 -> 8.2.1 (✓ API compatible changes) * `rolldown-file-id`: 0.2.3 -> 0.2.4 (✓ API compatible changes) * `rolldown-notify-debouncer-full`: 0.6.0 -> 0.6.1 (✓ API compatible changes) * `rolldown-notify-debouncer-mini`: 0.7.0 -> 0.7.1 <details><summary><i><b>Changelog</b></i></summary><p> ## `rolldown-notify-types` <blockquote> ## [2.0.1](rolldown-notify-types-v2.0.0...rolldown-notify-types-v2.0.1) - 2025-11-16 ### Other - update rust toolchain to 1.90.0 </blockquote> ## `rolldown-notify` <blockquote> ## [8.2.1](rolldown-notify-v8.2.0...rolldown-notify-v8.2.1) - 2025-11-16 ### Fixed - emit `remove` event if add watch fails due to non-existing path for kqueue watcher ([#6](#6)) - throw fsevents stream start error properly ([#4](#4)) ### Other - add kqueue tests ([#5](#5)) - reuse the same `ReadDirectoryChangesW` handle for watching a file in the same directory ([#3](#3)) - migrate to rust edition 2024 ([#2](#2)) - add benchmark for .paths_mut ([#1](#1)) - fix test failure with macOS kqueue - add test helpers and tests ([notify-rs#728](https://github.com/rolldown/notify/pull/728)) - `FsEventWatcher` crashes when dealing with empty path ([notify-rs#718](https://github.com/rolldown/notify/pull/718)) - update rust toolchain to 1.90.0 </blockquote> ## `rolldown-file-id` <blockquote> ## [0.2.4](rolldown-file-id-v0.2.3...rolldown-file-id-v0.2.4) - 2025-11-16 ### Other - migrate to rust edition 2024 ([#2](#2)) </blockquote> ## `rolldown-notify-debouncer-full` <blockquote> ## [0.6.1](rolldown-notify-debouncer-full-v0.6.0...rolldown-notify-debouncer-full-v0.6.1) - 2025-11-16 ### Other - migrate to rust edition 2024 ([#2](#2)) </blockquote> ## `rolldown-notify-debouncer-mini` <blockquote> ## [0.7.1](rolldown-notify-debouncer-mini-v0.7.0...rolldown-notify-debouncer-mini-v0.7.1) - 2025-11-16 ### Other - updated the following local packages: rolldown-notify-types, rolldown-notify </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fsevents seems to not allow watching more than 4096 paths at once.
But notify did not throw an error when that happened.
This PR makes the error to be thrown properly.