Skip to content

More Replay type fixes, added replay component to package.json#1376

Merged
matux merged 2 commits into
masterfrom
matux/fix-more-type-issues
Oct 14, 2025
Merged

More Replay type fixes, added replay component to package.json#1376
matux merged 2 commits into
masterfrom
matux/fix-more-type-issues

Conversation

@matux

@matux matux commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

Description of the change

  • I couldn't make the Replay type work for some reason, I kept getting this error in the examples that use TS:
src/index.ts(19,3): error TS2741: Property 'prototype' is missing in type 'Replay' but required in type 'typeof Replay'.

I tried multiple things, turn it into an interface, remove the constructor, remove the getters, remove any reference to Recorder, nothing worked, so I went with the typical pattern we use for components.
Will try again when we add Typescript.

  • Since recorder.d.ts isn't a component anymore, the type can be defined correctly.
  • package.json was missing the definition for the replay component (was still using recorder)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

@matux matux self-assigned this Oct 14, 2025
@matux matux enabled auto-merge (squash) October 14, 2025 14:58
@matux matux merged commit c467d3f into master Oct 14, 2025
6 checks passed
@matux matux deleted the matux/fix-more-type-issues branch October 14, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants