Call _onComplete on all leading replay discard paths#1369
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where ScheduledCapture._onComplete wasn't being called on all cleanup paths, causing memory leaks of trailing statuses for replay IDs. The change moves the _onComplete call to the discard method to ensure it's called consistently, and extracts the posting logic into a reusable _post method.
- Moved
_onCompletecallback fromsendLeadingtodiscardmethod for consistent cleanup - Extracted HTTP posting logic into a private
_postmethod for better code organization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
matux
force-pushed
the
matux/fix-cleanup
branch
from
3763b46 to
2ad267e
Compare
waltjones
approved these changes
Oct 13, 2025
matux
added a commit
that referenced
this pull request
Oct 13, 2025
5 tasks
matux
added a commit
that referenced
this pull request
Oct 13, 2025
* Add _pendingContextIfReady and rename cursor in context (#1364) * Remove index.js from tests (#1366) * Init logger on replay integration tests to log errors (#1367) * Rethrow span export errors to prevent unnecessary sendIfReady calls (#1368) * Call _onComplete on all leading replay discard paths (#1369) * `ScheduledStreamCapture` to survive multiple rrweb checkouts (#1371)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes
ScheduledCapture._onCompletenot being called on some cleanup paths causing trailing statuses for a given replayId to leak.This PR also extracts the tracing post call into a private post function in ScheduledCapture.
Type of change