Init logger in replay integration tests to log errors#1367
Merged
matux merged 1 commit intoOct 11, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR initializes the internal logger in replay integration tests to enable error logging and improve debugging capabilities. The change ensures consistent logging across all replay integration test files by setting the log level to 'warn' in each test's beforeEach hook.
- Adds logger initialization to six replay integration test files
- Standardizes logger configuration with 'warn' log level across all tests
- Removes redundant local logger mock in e2e.test.js in favor of the real logger
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/replay/integration/sessionRecording.test.js | Adds logger import and initialization in both test suites |
| test/replay/integration/replayManager.test.js | Adds logger import and initialization, removes unused imports |
| test/replay/integration/replayManager.bufferIndex.test.js | Adds logger import and initialization, removes unused import |
| test/replay/integration/replayManager.bufferIndex.checkoutResilience.test.js | Moves logger import to top and adds initialization |
| test/replay/integration/queue.replayManager.test.js | Adds logger import and initialization |
| test/replay/integration/e2e.test.js | Adds logger import and initialization, replaces mock logger with real logger spies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
matux
force-pushed
the
matux/init-logger-on-some-tests
branch
from
da05551 to
81d9378
Compare
matux
force-pushed
the
matux/remove-test-index
branch
2 times, most recently
from
bbeee13 to
66c7036
Compare
Base automatically changed from
matux/remove-test-index
to
feature/matux/streaming-capture
October 11, 2025 15:19
matux
force-pushed
the
matux/init-logger-on-some-tests
branch
from
81d9378 to
feb9577
Compare
waltjones
approved these changes
Oct 11, 2025
matux
added a commit
that referenced
this pull request
Oct 13, 2025
5 tasks
matux
added a commit
that referenced
this pull request
Oct 13, 2025
* Add _pendingContextIfReady and rename cursor in context (#1364) * Remove index.js from tests (#1366) * Init logger on replay integration tests to log errors (#1367) * Rethrow span export errors to prevent unnecessary sendIfReady calls (#1368) * Call _onComplete on all leading replay discard paths (#1369) * `ScheduledStreamCapture` to survive multiple rrweb checkouts (#1371)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is being merged into a feature branch:
feature/matux/streaming-captureDescription of the change
This PR initializes our internal
loggerin replay integration tests in order to log errors and facilitate debugging.Type of change