Remove index.js from tests#1366
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes index.js files from the test directory structure to prevent Web Test Runner (WTR) from executing tests multiple times due to duplicate test exports.
- Removes three index.js files that were re-exporting test modules
- Eliminates test duplication in the replay test suite
- Maintains test functionality while improving test runner efficiency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/replay/unit/index.js | Removes unit test aggregator that exported replay manager, API, and queue tests |
| test/replay/integration/index.js | Removes integration test aggregator that exported session recording, API, replay manager, queue, and e2e tests |
| test/replay/index.js | Removes top-level test aggregator that exported both unit and integration test modules |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Base automatically changed from
matux/rename-cursor
to
feature/matux/streaming-capture
October 11, 2025 15:07
matux
force-pushed
the
matux/remove-test-index
branch
from
0dcae0a to
bbeee13
Compare
matux
force-pushed
the
feature/matux/streaming-capture
branch
from
b9d39b3 to
02a9fd7
Compare
matux
force-pushed
the
matux/remove-test-index
branch
from
bbeee13 to
66c7036
Compare
waltjones
approved these changes
Oct 11, 2025
matux
added a commit
that referenced
this pull request
Oct 13, 2025
5 tasks
matux
added a commit
that referenced
this pull request
Oct 13, 2025
* Add _pendingContextIfReady and rename cursor in context (#1364) * Remove index.js from tests (#1366) * Init logger on replay integration tests to log errors (#1367) * Rethrow span export errors to prevent unnecessary sendIfReady calls (#1368) * Call _onComplete on all leading replay discard paths (#1369) * `ScheduledStreamCapture` to survive multiple rrweb checkouts (#1371)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Note
This is being merged into a feature branch:
feature/matux/streaming-captureThis PR removes some
index.jsfiles that were making WTR check several tests twice.Type of change