Add _pendingContextIfReady and rename bufferCursor to cursor in pending context#1364
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors the ScheduledCapture class to improve naming consistency and testing capabilities. The change renames bufferCursor to the more generic cursor and introduces a specialized function to check pending context readiness.
- Renamed
bufferCursorproperty tocursorthroughout the codebase for better generic naming - Added
_pendingContextIfReadymethod to centralize readiness checking logic - Refactored
sendIfReadymethod to use the new helper function
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/browser/replay/scheduledCapture.js | Implements the core changes: renaming bufferCursor to cursor and adding _pendingContextIfReady method |
| test/replay/unit/scheduledCapture.test.js | Updates test cases to use new cursor property and adds comprehensive tests for _pendingContextIfReady |
| test/replay/integration/replayManager.bufferIndex.test.js | Updates integration tests to use new cursor property and _pendingContextIfReady method |
| test/replay/integration/replayManager.bufferIndex.checkoutResilience.test.js | Updates resilience tests to use new cursor property |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
waltjones
approved these changes
Oct 11, 2025
matux
added a commit
that referenced
this pull request
Oct 11, 2025
matux
added a commit
that referenced
this pull request
Oct 13, 2025
5 tasks
matux
added a commit
that referenced
this pull request
Oct 13, 2025
* Add _pendingContextIfReady and rename cursor in context (#1364) * Remove index.js from tests (#1366) * Init logger on replay integration tests to log errors (#1367) * Rethrow span export errors to prevent unnecessary sendIfReady calls (#1368) * Call _onComplete on all leading replay discard paths (#1369) * `ScheduledStreamCapture` to survive multiple rrweb checkouts (#1371)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is being merged into a feature branch:
feature/matux/streaming-captureDescription of the change
Added specialized function to test pending context readiness to facilitate testing between scheduled capturing classes and renamed
bufferCursortocursorto be more generic between said classes.CAT-485/extended-post-trigger-replay-duration
Type of change