Renamed LeadingCapture to ScheduledCapture and related#1363
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames LeadingCapture to ScheduledCapture to better reflect its generic utility nature for coordinating delayed, cursor-based captures rather than being specific to "leading" replay scenarios. The refactoring improves code clarity by emphasizing what the class actually does: schedule replay captures with timer coordination.
- Renamed class and file from
LeadingCapture/leadingCapture.jstoScheduledCapture/scheduledCapture.js - Updated all references and variable names throughout the codebase
- Enhanced class documentation to reflect its generic utility purpose
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/replay/unit/scheduledCapture.test.js | Updated all test references from LeadingCapture to ScheduledCapture and related variable names |
| test/replay/integration/replayManager.bufferIndex.test.js | Updated test references from _leadingCapture to _scheduledCapture |
| test/replay/integration/replayManager.bufferIndex.checkoutResilience.test.js | Updated test references from _leadingCapture to _scheduledCapture |
| src/browser/replay/scheduledCapture.js | Renamed class and updated documentation to emphasize generic utility nature |
| src/browser/replay/replayManager.js | Updated import and all internal references from leading-specific to scheduled-specific naming |
Comments suppressed due to low confidence (1)
src/browser/replay/replayManager.js:1
- Error message still references 'leading replay' but should be updated to 'scheduled replay' to match the renamed class.
import * as _ from '../../utility.js';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
waltjones
approved these changes
Oct 10, 2025
matux
force-pushed
the
matux/separate-leading-capture-concerns
branch
from
559b5ee to
95e69b0
Compare
matux
force-pushed
the
matux/separate-leading-capture-concerns
branch
from
95e69b0 to
4e485c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
The class is a generic utility for coordinating delayed, cursor-based captures. It has no knowledge of "leading" vs "trailing" replays or trigger types. The new name better reflects what it actually does: schedule replay captures with timer coordination.
Changes
leadingCapture.js->scheduledCapture.jsLeadingCapture→ScheduledCapture_leadingCapture->_scheduledCapturein ReplayManagerType of change