Use trigger config for pre/post duration and recorder config#1362
Merged
Conversation
b383984 to
ffefa59
Compare
matux
approved these changes
Oct 10, 2025
|
|
||
| this.tracing?.configure(this.options); | ||
| this.replayManager?.recorder?.configure(this.options); | ||
| this.replayManager?.configure(this.options); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Replaces recorder options
maxSecondsandpostDurationwith trigger configs driver by the replayManager config. This allows each trigger to independently define itspreDurationandpostDuration. This also derivesmaxPreDurationfrom the trigger config, replacingmaxSecondsin the recorder initialization.The heart of this update is in
ReplayManager.capture, wheretrigger.preDurationandtrigger.postDurationfor the matching trigger are now used for the current capture request.Notes:
configuremethod) is now driven throughReplayManager.configure, keeping the previous behavior.postDurationbehavior has been updated, butpreDurationbehavior is left as is. (Trailing duration is by default the length of the current recording buffer, and doesn't (yet) explicitly usepreDuration.)Type of change
Development