Add framework session attribute#1357
Merged
Merged
Conversation
shankj3
reviewed
Oct 8, 2025
| 'browser.mobile': navigator.userAgentData?.mobile, | ||
| 'browser.platform': navigator.userAgentData?.platform, | ||
| 'client.address': '$remote_ip', // updated at the API | ||
| 'rollbar.notifier.framework': 'browser-js', |
There was a problem hiding this comment.
just curious - Any reason we're doing it here and not where we set everything else notifier related?
Contributor
Author
There was a problem hiding this comment.
Doesn't rely on the config options, which is the real reason those other options are set in core.js.
I suppose when it's not a static value, that will inform where best to factor it.
shankj3
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Add
rollbar.notifier.frameworksession attribute.Type of change
Checklists
Development