Promote ReplayManager to component, replacing Recorder#1348
Merged
Conversation
matux
reviewed
Oct 7, 2025
matux
left a comment
matux
left a comment
Contributor
There was a problem hiding this comment.
Looks great! 100% agree with changing options name from recorder to replay, and fully encapsulating the Recorder in ReplayManager, and the exporting doing the full exporting round including post.
This is much cleaner and straightforward! 👏 😀
| this._map = new Map(); | ||
| this._recorder = recorder; | ||
| this._api = api; | ||
| this._recorder = new Recorder(options); |
matux
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR replaces
Recorderas a component passed to core.js withReplayManagerand encapsulatesRecorderandreplayPredicateswithinReplayManager. This allows all replay classes to be removed when replay is not added as a component.This PR also renames the
recorderconfig key toreplay.Type of change
Checklists
Development