Update replay triggers and config defaults#1346
Merged
Merged
Conversation
9af3743 to
db5706a
Compare
matux
reviewed
Oct 6, 2025
matux
left a comment
Contributor
There was a problem hiding this comment.
Found two potential issues, everything else looks great.
Contributor
Author
|
Good catch on those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Replay triggers are predicates that decide whether conditions to capture and send a replay are met. A replay context is the relevant state at the time the predicates are applied. This context is matched against the configured triggers to determine whether a replay should be captured.
Trigger defaults in the config have been updated to both improve readability of the config and simplify applying the defaults in code.
This PR updates replay triggers to
Note
The recorder is not updated to use new trigger options yet. This will be added in a follow up PR.
Type of change
Checklists
Development