Extract _canSendReplay into its own private ReplayManager static function#1343
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extracts replay validation logic into a dedicated static method to improve testability and maintainability. The _canSendReplay method centralizes the logic for determining whether a replay can be sent based on API response and headers.
- Extracted inline replay validation logic into
ReplayManager._canSendReplaystatic method - Added header normalization to handle case-insensitive headers and whitespace trimming
- Comprehensive test coverage for the new static method including edge cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/browser/replay/replayManager.js | Added static _canSendReplay method with header normalization and refactored sendOrDiscardReplay to use it |
| test/replay/unit/replayManager.test.js | Added comprehensive test suite for the new _canSendReplay method covering various scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
waltjones
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Extracted
_canSendReplayas a testable static method with header normalization inReplayManager.