Renamed ReplayManager.add to ReplayManager.capture#1337
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the session replay functionality by renaming the primary method from add to capture throughout the codebase for better clarity and consistency. The change improves code readability by using a more descriptive method name that better reflects the purpose of capturing replay sessions.
- Renamed
ReplayManager.add()toReplayManager.capture()with updated documentation - Updated all production code references to use the new method name
- Enhanced code comments for replay coordination and telemetry export logic
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/browser/replay/replayManager.js | Renamed method from add to capture and added clarifying comments |
| src/queue.js | Updated method call to use capture instead of add |
| test/replay/unit/replayManager.test.js | Updated test calls to use new method name |
| test/replay/unit/queue.replayManager.test.js | Updated mock method and test assertions |
| test/replay/integration/sessionRecording.test.js | Updated spy variables and assertions |
| test/replay/integration/replayManager.test.js | Updated test method calls |
| test/replay/integration/queue.replayManager.test.js | Updated mock and test assertions |
| test/replay/integration/e2e.test.js | Updated spy variables and test assertions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
matux
force-pushed
the
matux/rename-add-to-capture
branch
from
ec0c489 to
1461143
Compare
matux
force-pushed
the
matux/rename-add-to-capture
branch
from
1461143 to
13789ae
Compare
waltjones
approved these changes
Oct 1, 2025
matux
added a commit
that referenced
this pull request
Oct 2, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Note
PR Description by Copilot
This pull request refactors the session replay functionality by renaming the primary method from add to capture throughout the codebase for better clarity and consistency. The change improves code readability by using a more descriptive method name that better reflects the purpose of capturing replay sessions.