Fix typo in variable reference#1332
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo in the Recorder class where a readiness check was using an incorrect property name. The fix ensures that the condition properly references the _isReady property instead of the non-existent _ready property.
- Fixed variable reference from
this._readytothis._isReadyin the emit callback condition
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
brianr
approved these changes
Sep 30, 2025
waltjones
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This pull request introduces a minor fix to the
Recorderclass insrc/browser/replay/recorder.js. The change ensures that the readiness check uses the correct property name, improving reliability in snapshot event handling.emitcallback to usethis._isReadyinstead ofthis._readyfor tracking readiness when aFullSnapshotevent occurs.Type of change