Convert core.js to class#1325
Merged
Merged
Conversation
matux
approved these changes
Sep 23, 2025
matux
left a comment
matux
left a comment
Contributor
There was a problem hiding this comment.
There are two functions that still use the prototype syntax in lines 518:526:
Rollbar.prototype.loadFull = function () {
logger.info(
'Unexpected Rollbar.loadFull() called on a Notifier instance. This can happen when Rollbar is loaded multiple times.',
);
};
Rollbar.prototype._createItem = function (args) {
return _.createItem(args, logger, this);
};Not sure if this intentional.
Contributor
Author
|
Overlooked, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Converts core.js to class syntax. More changes will follow. This gets the file indentation diff out of the way in one PR.
Note:
This refactor preserves the previous behavior of allowing
Rollbarto behave like an instance after callingRollbar.init().Type of change
Checklists
Development