Simplifies getting replay id attribute from data in queue#1323
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the codebase by removing the unused getItemAttribute utility function and replacing its single usage with direct attribute access. The change reduces code complexity while maintaining the same functionality for retrieving replay ID attributes from queue data.
Key changes:
- Removed the
getItemAttributehelper function and its tests - Replaced the function call with inline attribute finding logic using modern JavaScript syntax
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utility.js | Removes the getItemAttribute function and its export |
| test/utility.test.js | Removes tests for the deleted getItemAttribute function |
| src/queue.js | Replaces getItemAttribute call with direct attribute access using array find method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
waltjones
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR simplifies how we get the replay id attribute from data with direct attribute access and removes the now unused
getItemAttributeutility function.