Enable request headers and add replay-id header#1310
Merged
Conversation
waltjones
force-pushed
the
waltjones/replay-id-request-header
branch
from
e844662 to
5e56559
Compare
waltjones
force-pushed
the
waltjones/replay-id-request-header
branch
from
5e56559 to
bfaf2f6
Compare
matux
approved these changes
Sep 18, 2025
matux
left a comment
matux
left a comment
Contributor
There was a problem hiding this comment.
The important stuff looks good, just a super minor non-blocking comment.
Comment on lines
+89
to
+91
| for (const h of Object.keys(headers || {})) { | ||
| request.setRequestHeader(h, headers[h]); | ||
| } |
Contributor
There was a problem hiding this comment.
Nitpick:
for (const [h, v] of Object.entries(headers ?? {})) {
request.setRequestHeader(h, v);
}I think this is more idiomatic.
non-blocking
| callback, | ||
| transportFactory, | ||
| ) { | ||
| }) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR enables sending the
X-Rollbar-Replay-Idrequest header, and sending arbitrary headers in general. To facilitate this and better manage the long arguments list for transport, transport arguments are refactored to use a params object.Type of change
Development