Telemetry: enable dom events#1309
Merged
Merged
Conversation
matux
approved these changes
Sep 17, 2025
matux
left a comment
matux
left a comment
Contributor
There was a problem hiding this comment.
This looks great!!! Complex made simple!
Some comments, but won't block on them.
| }[name].call(this, evt); | ||
| } catch (exc) { | ||
| // TODO: Not sure what to do here | ||
| console.log(`${name} handler error`, evt, exc, exc.stack); |
Contributor
There was a problem hiding this comment.
The cool thing about having a type-theoretic system, this state would become flat-out unrepresentable.
| kinds = []; | ||
| mediaTypes = []; | ||
| const objs = [...evt.dataTransfer.files, ...evt.dataTransfer.items]; | ||
| //const objs = Array.from(evt.dataTransfer.files) || Array.from(evt.dataTransfer.items); |
|
|
||
| handleFocus(evt) { | ||
| const type = evt.type; | ||
| const element = evt.target.window ? 'window' : domUtil.elementString(evt.target); |
Contributor
There was a problem hiding this comment.
Suggested change
| const element = evt.target.window ? 'window' : domUtil.elementString(evt.target); | |
| const element = evt.target?.window ? 'window' : domUtil.elementString(evt.target); |
IFF there is a chance evt.target could be null.
Contributor
Author
There was a problem hiding this comment.
Don't think so, but doesn't hurt to add it.
| handleForm(evt) { | ||
| // TODO: implement form event handling | ||
| const type = evt.type; | ||
| const elementString = evt.target.window ? 'window' : domUtil.elementString(evt.target); |
Contributor
There was a problem hiding this comment.
Suggested change
| const elementString = evt.target.window ? 'window' : domUtil.elementString(evt.target); | |
| const elementString = evt.target?.window ? 'window' : domUtil.elementString(evt.target); |
Same as above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Enables telemetry events for DOM events
And updates the connectivity event.
Type of change
Checklists
Development