Skip to content

Convert Telemeter to class#1308

Merged
waltjones merged 1 commit into
masterfrom
waltjones/telemeter-class
Sep 12, 2025
Merged

Convert Telemeter to class#1308
waltjones merged 1 commit into
masterfrom
waltjones/telemeter-class

Conversation

@waltjones

Copy link
Copy Markdown
Contributor

Description of the change

Convert Telemeter to class syntax.

Type of change

  • Refactor

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

@matux matux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread src/telemetry.js
};

// Only intended to be used internally by the notifier
_captureRollbarItem(item) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for another PR, but as part of modernization, we could start using # to define private functions in classes.

@waltjones waltjones Sep 12, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. For this one I just wanted to get the indentation in the file done.

@waltjones waltjones merged commit 7145fbc into master Sep 12, 2025
4 checks passed
@waltjones waltjones deleted the waltjones/telemeter-class branch September 12, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants