Convert Instrumenter to a class#1307
Merged
Merged
Conversation
matux
approved these changes
Sep 10, 2025
matux
left a comment
matux
left a comment
Contributor
There was a problem hiding this comment.
It all looks good! This is great, @waltjones!
Contributor
|
Interesting, it seems the Angular example broke. I'm not sure why. |
Contributor
Author
|
Angular failed on where package.json has In a separate run, react-19-typescript failed on The examples don't have lock files, so there's no way to know what versions CI will try to resolve. There seems to be something going on with npm today causing multiple issues with package resolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Development