Export telemetry from ReplayMap#1305
Conversation
waltjones
force-pushed
the
waltjones/telemetry-export-from-replaymap
branch
from
f68ca86 to
a672269
Compare
matux
left a comment
matux
left a comment
There was a problem hiding this comment.
Just one comment to understand what exporting a telemetry span means
| Telemeter.prototype.exportTelemetrySpan = function (attributes = {}) { | ||
| if (this.telemetrySpan) { | ||
| this.telemetrySpan.end(attributes); | ||
| this.telemetrySpan = this.tracing.startSpan('rollbar-telemetry', {}); | ||
| } | ||
| }; |
There was a problem hiding this comment.
I'm not sure I understand the intention, what is this function exporting and where to? Or is this just reseting/restarting the telemetry span? Or does ending the telemetrySpan moves data somewhere else?
There was a problem hiding this comment.
span.end() always causes an export. That's part of the standard tracing behavior.
This method ensures the currently open span is ended and exported so that it can be included in the next payload, and opens a new span to continue capturing telemetry events.
There was a problem hiding this comment.
And no new span is gonna be opened if no current telemetry span exist.
2 participants
Description of the change
Refactor to trigger telemetry export from ReplayMap.
Type of change
Checklists
Development