Initial migration of react native tests#1301
Merged
Merged
Conversation
waltjones
approved these changes
Sep 8, 2025
matux
added a commit
that referenced
this pull request
Sep 8, 2025
* Initial Karma to Web Test Runner migration (#1289) * Fix hanging tests and expand WTR migration (#1295) * Migrate example tests for Web Test Runner (#1298) * Migrate browser transform and core tests for Web Test Runner (#1299) * Migrate browser tests from Karma to Web Test Runner (#1300) * Initial migration of react native tests (#1301) * Remove Grunt and Karma (#1302)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
React Native tests have been disabled due to multiple issues we won't handle right now:
React native's
src/react-native/transport.jsis using a 10 year old libraryBufferjust to get thebyteLengthof some utf8 data. This library is supposed to be part of node now. Instead of:Should be imported as:
The other problem is that this dep isn't being added directly, it comes from a devDependency called node-libs-browser which is also extremely old and that I don't believe it's really in use.
Webpack does some magic and ends up shoving
bufferin the bundle because it sees it's being used.All in all, since the tests require a hybrid of node.js and browser environment to run, we need to solve these issues first before we can make these tests play nice with WTR.
That being said, an initial, basic migration has been done which is correct.
These tests will remain disabled for the time being.
Related issues
SDK-493/replace-karma-with-webtest-runner-for-modern-performant-browser