Fix hanging tests and expand WTR migration#1295
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes hanging tests in the Web Test Runner migration and expands test coverage to 358 passing tests across 31 files. The primary changes address test configuration issues and modernize Chai assertions for compatibility with the new test runner.
- Fixed hanging tests by changing
allowUncaughtfromtruetofalsein WTR config - Updated Chai assertions from legacy
.equal(true/false)to.be.true/.be.falsepatterns - Replaced problematic
expect(false).to.be.okassertions withassert.fail()calls - Fixed Queue.wait() double-callback issue with counter-based workaround
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| web-test-runner.config.mjs | Removed exclusions for previously hanging tests and fixed allowUncaught config |
| test/utility.test.js | Updated boolean assertions to use .be.true/.be.false |
| test/truncation.test.js | Modernized Chai assertions and fixed .be() usage |
| test/tracing/tracing.test.js | Updated boolean assertions for span recording state |
| test/tracing/span.test.js | Updated boolean assertions for span recording state |
| test/telemetry.test.js | Fixed .be() usage for boolean assertions |
| test/queue.test.js | Replaced expect(false).to.be.ok with assert.fail() and fixed wait callback issue |
| test/browser.replay.recorder.test.js | Updated boolean assertion for recorder state |
| .github/workflows/ci.yml | Split test runs and added Playwright browser installation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
waltjones
approved these changes
Aug 28, 2025
matux
added a commit
that referenced
this pull request
Sep 8, 2025
* Initial Karma to Web Test Runner migration (#1289) * Fix hanging tests and expand WTR migration (#1295) * Migrate example tests for Web Test Runner (#1298) * Migrate browser transform and core tests for Web Test Runner (#1299) * Migrate browser tests from Karma to Web Test Runner (#1300) * Initial migration of react native tests (#1301) * Remove Grunt and Karma (#1302)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR is being merged into a feature branch:
matux/wtr.This PR also enables the CI for all Pull Requests, not just the ones going to
master.Description of the change
Fixes all hanging tests in Web Test Runner migration and expands coverage: 358 tests passing across 31 test files (~90% of browser tests).
Note
Tests now run in 3.1s vs 24.3s (8x faster)!
Target branch:
matux/wtr(feature branch)Changes
Test Fixes
allowUncaught: falsein WTR configexpect(false).to.be.okwithassert.fail()and boolean assertions:.eql(true/false)→.to.be.true/falseCI Updates
Testing