Skip to content

Fix React depenedency to enable XCode 12 build#141

Merged
waltjones merged 1 commit into
rollbar:masterfrom
hosseintalebi:xcode-12-compatibility-with-react
Mar 19, 2021
Merged

Fix React depenedency to enable XCode 12 build#141
waltjones merged 1 commit into
rollbar:masterfrom
hosseintalebi:xcode-12-compatibility-with-react

Conversation

@hosseintalebi

@hosseintalebi hosseintalebi commented Oct 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of the change

Latest Xcode 12 fails to build if the module doesn't depend on React-Core. Please check the following link for me details: facebook/react-native#29633

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

facebook/react-native#29633

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Fix React depenedency to enable XCode 12 build
67dd334 
Latest Xcode 12 fails to build if the module doesn't depend on React-Core. Please check the following link for me details: react/react-native#29633 (comment)
@chris-hut

chris-hut commented Mar 18, 2021

Copy link
Copy Markdown

Any update if this can land, as this is causing us to have to us the XCode Legacy Build System

@waltjones waltjones self-requested a review March 19, 2021 01:37
waltjones
waltjones approved these changes Mar 19, 2021
View reviewed changes

@waltjones waltjones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@waltjones waltjones merged commit 3de133a into rollbar:master Mar 19, 2021
@waltjones

waltjones commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

Release will come asap.

@waltjones

waltjones commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

This is released in v0.9.2. https://github.com/rollbar/rollbar-react-native/releases/tag/v0.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waltjones waltjones waltjones approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hosseintalebi @chris-hut @waltjones