Skip to content

Fixed new 96 character access token fails validation.#654

Merged
danielmorell merged 1 commit into
masterfrom
fixed/SDK-470-new-96-char-access-token-fails-validation
Apr 17, 2025
Merged

Fixed new 96 character access token fails validation.#654
danielmorell merged 1 commit into
masterfrom
fixed/SDK-470-new-96-char-access-token-fails-validation

Conversation

@danielmorell

Copy link
Copy Markdown
Collaborator

Description of the change

This resolves an issue with the validation of our new 96 character access tokens. We were previously requireing access tokens be 32 characters long. This PR fixes that by allowing either a 32 character or 96 character token.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

  • Fix SDK-470

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added this to the v4.1.3 milestone Apr 17, 2025
@danielmorell danielmorell requested a review from brianr April 17, 2025 19:01
@linear

linear Bot commented Apr 17, 2025

Copy link
Copy Markdown

@brianr brianr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@danielmorell danielmorell merged commit 8183a16 into master Apr 17, 2025
@danielmorell danielmorell deleted the fixed/SDK-470-new-96-char-access-token-fails-validation branch April 17, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants