Fixed #651 Person::$extra must be an array and an object was given.#652
Merged
Merged
Conversation
brianr
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This resolves the issue with #651 by serializing the object passed to the extra parameter of
Person::__construct().It also moves the logic to prevent using the keys
id,email, andusernamefrom theDataBuilderclass to thePersonclass as this seems like a more logical location. As in thePersonconstructor it can prevent these keys being set no mater where the instance is being created from.Type of change
Related issues
Checklists
Development
Code review