Skip to content

added telemetry support#82

Merged
pawelsz-rb merged 12 commits into
masterfrom
pawel/telemetry
Apr 20, 2021
Merged

added telemetry support#82
pawelsz-rb merged 12 commits into
masterfrom
pawel/telemetry

Conversation

@pawelsz-rb

@pawelsz-rb pawelsz-rb commented Apr 7, 2021

Copy link
Copy Markdown
Collaborator

Description of the change

  • Added telemetry support for network and logger
  • By default, telemetry is disabled for both network and logger.
  • To initialize Telemetry with different options, a user can set it as following:
client := &http.Client{}
rollbar.SetTelemetry(rollbar.EnableNetworkTelemetry(client), rollbar.EnableLoggerTelemetry(),
	        rollbar.EnableNetworkTelemetryRequestHeaders(),
		rollbar.SetCustomQueueSize(100),
	)

client.Get(url) // this will be added to telemetry queue 
log.Println("some text") // this will be added to telemetry queue

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #82032

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@pawelsz-rb pawelsz-rb self-assigned this Apr 7, 2021
@pawelsz-rb pawelsz-rb marked this pull request as ready for review April 17, 2021 06:38
@pawelsz-rb pawelsz-rb removed their assignment Apr 17, 2021
@pawelsz-rb pawelsz-rb merged commit e2e8a88 into master Apr 20, 2021
@pawelsz-rb pawelsz-rb deleted the pawel/telemetry branch April 20, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants