heroku/rollbar and stvp/rollbar had diverged, bring them closer#1
Merged
Conversation
…neralize client functions, make a sync client implementation
…n configuration options
…appens as required
Contributor
Author
|
Testing webhook |
Contributor
|
@rokob What's the status of this PR? |
Contributor
Author
|
I am going to merge this, it is most of the things that needed to get done and it has all of the stuff from stvp that we want. I'll put up a few smaller PRs for other features. |
mback2k
pushed a commit
to mback2k/rollbar-go
that referenced
this pull request
Aug 4, 2019
Generalize/modularize support for custom stack trace extraction
12 tasks
This was referenced Jun 29, 2022
Merged
12 tasks
12 tasks
12 tasks
12 tasks
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stvp/rollbar had 55 commits that were not in the heroku/rollbar fork. This PR is intended to bring over the stuff that was added to stvp/rollbar into our notifier. Just doing a merge was a bit harder than essentially duplicating the work because the file structure had diverged too much.
I took the opportunity to also refactor some things related to how the internals of the client works, which allowed me to also create a synchronous client implementation.