Be more explicit about what URL.init we want to map to in RollbarReport#358
Merged
Conversation
waltjones
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This fixes an issue with certain configurations when using the Rollbar React Native SDK which depends on the native Apple Rollbar SDK.
When using Expo, for instance, this doesn't occur. But barebones React Native seems to end up with this issue. I honestly don't understand why.
This was first reported here: rollbar/rollbar-react-native#199, and seemed related to Xcode Cloud, but examples provided by the community demonstrated this is a more general issue.
Type of change