Fix a compilation issue present in Xcode 16 beta#349
Merged
Conversation
waltjones
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes a compilation issue in
RollbarCrashMonitor_CPPException.cppwhere the symbolsstd::terminate_handlerandstd::set_terminateused in the source weren't being found by the compiler.Libc++ is in the process of splitting larger headers into smaller modular headers. Previous to Libc++ 20, the smaller modular headers were being included transitively to avoid breaking existing code. In this case,
exceptionwas a transitive include oftypeinfo.More info: https://libcxx.llvm.org/DesignDocs/HeaderRemovalPolicy.html
This affects the new Xcode 16 which is currently in Beta 3.
Contribution by @dongdong945
@dongdong945 had previously contributed a fix for this in #347 (thank you!).
Type of change
Related issues