Renamed RollbarCrashReportTests to RollbarReportTests#314
Merged
Conversation
mudetroit
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR renames
RollbarCrashReportTeststoRollbarReportTeststo follow the new module schema post-KSCrashintegration whereRollbarCrashReportis now known asRollbarReportand our crash monitoring and recording module asRollbarCrash.This PR also cleans up some unused testing
xcschemes.It seems the
RollbarReporttests weren't being run by the CI, part of the cleanup of schemes included makingRollbarReportpart of theRollbarNotifierxcschemeand removing the separateRollbarCrashReportscheme. This seem to have inadvertently fix the issue and running these tests from the CI uncovered a minor issue in the way we were writing crash reports, where we were using the current time zone instead of GMT.This has been fixed in this PR, too.
Type of change
Checklists
Development
Code review