Fixed log level ordering to standard#293
Merged
Merged
Conversation
|
This pull request has been linked to Shortcut Story #126937: Apple SDK: Fix ordering of logging levels. |
cyrusradfar
approved these changes
Jun 6, 2023
cyrusradfar
left a comment
cyrusradfar
left a comment
There was a problem hiding this comment.
Thanks for the quick turn. One nit. Although we appreciate the rename helps standardize to a convention, but in the future, consider breaking into two PRs so we can limit the risk of the quick fix.
Collaborator
Author
I understand, couldn't help the OCD, next time I'll do a proper separate PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes the ordering of log levels which was very wrong. This issue was reported today.
This incorrect ordering introduces issues when defining minimum level for logging since we use the integer ordering of the enum to check whether we should record a log or not.
This can be seen in the
shouldSkipReporting:function inRollbarLogger: https://github.com/rollbar/rollbar-apple/blob/master/RollbarNotifier/Sources/RollbarNotifier/RollbarLogger.m#L179Type of change
Related issues
Checklists
Development
Code review