Merge master into v1#1177
Merged
Merged
Conversation
* Add plugin hook for documentSymbol * Better handling of null/missing name tokens * fix lint issues
* Move symbol creation to symbolUtils * Fix workspaceSymbol handling * Fix tests * Fix lint issues
* Move symbol creation to symbolUtils * Fix workspaceSymbol handling * Fix tests * Fix lint issues * Mostly fixed tests * Fix workspace symbols missing containerName
* Upgrade to @rokucommunity/logger * Add original logger class back * @rokucommunity/logger v0.3.4
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.13 to 6.2.1. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.13...v6.2.1) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bronley Plumb <[email protected]>
…#1148) * fix: resolve the stagingDir option relative to the bsconfig.json file * chore: add unit test * Fix windows paths --------- Co-authored-by: Bart van den Ende <[email protected]> Co-authored-by: Bronley Plumb <[email protected]>
* Fix crash when diagnostic is missing range * improve unit test
markwpearce
requested changes
May 11, 2024
markwpearce
left a comment
markwpearce
left a comment
Collaborator
There was a problem hiding this comment.
Looking forward to getting parity with master again.
We should cleanup the the TypeChainEntry class now that it has astNode.
* fixed some tests as well * remove commented out code
markwpearce
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The master ->release-1.0.0 merge was a bit busy, so this is a dedicated PR to help with reviewing the changes to ensure that everything was done properly.
Extra changes:
astNodeto the TypeChain so we could better supportcannotFindFunctiondiagnostics introduced recently in masterTODO: