Skip to content

Fix roDateTime compatibility issue#1163

Merged
TwitchBronBron merged 1 commit into
release-1.0.0from
fix_roDateTime_compatibility_issue
May 8, 2024
Merged

Fix roDateTime compatibility issue#1163
TwitchBronBron merged 1 commit into
release-1.0.0from
fix_roDateTime_compatibility_issue

Conversation

@markwpearce

@markwpearce markwpearce commented May 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Types would get messed up if there were duplicate definitions of members.

This could happen from the scraper.

This pr fixes the scraper so that it fixes all the overloaded methods in interfaces automatically.

fixes: #1162

these are all the overloads the scraper fixed automatically on last run:

Fixed overloaded method ifAudioResource.trigger
Fixed overloaded method ifByteArray.writefile
Fixed overloaded method ifByteArray.readfile
Fixed overloaded method ifByteArray.appendfile
Fixed overloaded method ifByteArray.getcrc32
Fixed overloaded method ifDateTime.toisostring
Fixed overloaded method ifDraw2D.drawscaledobject
Fixed overloaded method ifFontRegistry.getdefaultfont
Fixed overloaded method ifSGNodeField.observefield
Fixed overloaded method ifSGNodeField.observefieldscoped
Fixed overloaded method ifStringOps.mid
Fixed overloaded method ifStringOps.instr
Fixed overloaded method ifStringOps.startswith
Fixed overloaded method ifStringOps.endswith
Fixed overloaded method ifToStr.tostr
Fixed overloaded method ifVideoPlayer.setdestinationrect

@markwpearce markwpearce added this to the v1.0.0 milestone May 8, 2024
@TwitchBronBron
TwitchBronBron merged commit 0f4e108 into release-1.0.0 May 8, 2024
@TwitchBronBron
TwitchBronBron deleted the fix_roDateTime_compatibility_issue branch May 8, 2024 20:07
@markwpearce markwpearce mentioned this pull request May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@markwpearce @TwitchBronBron