Skip to content

Diagnostics Refactor: DiagnosticManager#1136

Merged
TwitchBronBron merged 11 commits into
release-1.0.0from
DiagnosticsManager
May 6, 2024
Merged

Diagnostics Refactor: DiagnosticManager#1136
TwitchBronBron merged 11 commits into
release-1.0.0from
DiagnosticsManager

Conversation

@markwpearce

Copy link
Copy Markdown
Collaborator

Refactors Diagnostics so ALL diagnostics need to be registered through DiagnosticManager , publically available through Program

DiagnosticManager has the following features:

  • a single diagnostic can be attached to multiple contexts
  • contexts optionally include scope, tags or particular Ast Nodes
  • if the same diagnostic is registered with a different scope context, it is added a related information
  • individual diagnostic contexts can be cleared - if all the contexts are cleared for a diagnostic, then the diagnostic is automatically removed.

@markwpearce markwpearce added this to the v1.0.0 milestone Apr 16, 2024

@TwitchBronBron TwitchBronBron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a bunch of suggestions. But I love how much this cleans up the project and streamlines diagnostic management!

Comment thread src/DiagnosticManager.ts
Comment thread src/DiagnosticManager.ts Outdated
Comment thread src/DiagnosticManager.ts Outdated
Comment thread src/DiagnosticManager.ts Outdated
Comment thread src/Program.ts Outdated
Comment thread src/ProgramBuilder.ts
Comment thread src/files/BscFile.ts Outdated
Comment thread src/util.ts Outdated
Comment thread src/DiagnosticManager.ts Outdated
@markwpearce
markwpearce requested a review from TwitchBronBron May 4, 2024 01:35
@TwitchBronBron
TwitchBronBron merged commit 9ec2970 into release-1.0.0 May 6, 2024
@TwitchBronBron
TwitchBronBron deleted the DiagnosticsManager branch May 6, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants