Fix bug in range and position caching#1127
Merged
Merged
Conversation
|
|
||
| // eslint-disable-next-line no-bitwise | ||
| const key = (startLine << 52) + (startCharacter << 39) + (endLine << 26) + (endCharacter << 13); | ||
| const key = (endCharacter << 24) + (endLine << 16) + (startLine << 8) + startCharacter; |
Member
There was a problem hiding this comment.
Using 8 bits per number only gives us a max of 255 lines in a file or 255 characters in a line before this key overflows. That's far too small.
TwitchBronBron
approved these changes
Apr 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1104