Update FileClassifier.cs#2
Closed
MichalPavlik wants to merge 1 commit intorokonec:rokonec/6761-immutable-files-up-to-datefrom
MichalPavlik:patch-1
Closed
Update FileClassifier.cs#2MichalPavlik wants to merge 1 commit intorokonec:rokonec/6761-immutable-files-up-to-datefrom MichalPavlik:patch-1
MichalPavlik wants to merge 1 commit intorokonec:rokonec/6761-immutable-files-up-to-datefrom
MichalPavlik:patch-1
Conversation
Author
|
Just a test |
rokonec
pushed a commit
that referenced
this pull request
Jan 23, 2023
Fixes dotnet#6773 Context Supersedes dotnet#8213 and dotnet#8282 Symlinked files were not embedded into binlog - previous solution was too much focused on symlinks and hence requried nontrivial code to properly distinguish aymlinks with available contnet. Alternate approach - proceed with adding file as soon as it has available content Testing Preexisting unit test is excercising the scenario. Added a case for empty file - that still should not be added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test
Fixes #
Context
Changes Made
Testing
Notes