Repository navigation
Conversation
Signed-off-by: Ace <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联
这是对已合并 PR #162 的 review follow-up,继续处理 Issue #69 中 LLM Provider 的 timeout/retry boundary。
本次改动
APIConnectionError,使其进入 Provider 的网络重试分支。APIConnectionError,使其进入 Provider 的网络重试分支。验证结果
19 passed, 45 deselectedgit diff --check:通过完整运行两个 Provider 测试文件的结果为:
39 passed, 25 failed。这 25 个失败均出现同一个既有导入错误:
错误来源为
py-runtime/src/sztu_code/core/prompts/system_prompt.py的主线 prompt 模块导入,与本 PR 修改的 Provider 和测试文件无关。本 PR 不修改该 prompt 命名问题,也不将其隐藏为通过。范围说明
本 PR 只处理 Provider 层的 SDK 连接异常重试和 deadline 最终检查,不声称完整解决 Issue #69。工具调用 timeout、权限等待与 pending request 清理、Parent/Subagent deadline 传播、context compaction、cleanup、Trace 以及完整生命周期集成测试仍属于后续独立工作。
本次只修改 Python Provider 和对应单元测试,因此未运行 TypeScript/桌面端检查。
GitHub CI 状态
PR #164 的两个 GitHub Actions 均已失败,但失败位置不在本 PR 修改的 4 个 Python 文件中,并且在同一
origin/main基线的 push CI 中复现:ECONNREFUSED、sztu_code.core.prompts.Sztubuddy导入缺失、图片格式断言等。origin/main 对照运行linuxdeploy处理@napi-rs/canvas-linux-x64-musl/skia.linux-x64-musl.node时执行ldd失败。origin/main 对照运行这两类失败在
origin/main对照运行中也出现,说明它们是仓库当前 CI/基线问题,不是本 PR 的 Provider 改动引入。本 PR 仅修改 Python LLM Provider 与相应单元测试,不将这些无关失败伪装为通过或扩大本 PR 范围。