Skip to content

testscript: remove "large files differ" diff size limit#206

Merged
mvdan merged 1 commit intorogpeppe:masterfrom
mvdan:big-diff
Mar 22, 2023
Merged

testscript: remove "large files differ" diff size limit#206
mvdan merged 1 commit intorogpeppe:masterfrom
mvdan:big-diff

Conversation

@mvdan
Copy link
Copy Markdown
Collaborator

@mvdan mvdan commented Mar 22, 2023

(see commit message)

Now that we no longer have to worry about pkg/diff's quadratic space
memory usage, we can remove this limitation.

Note that big_diff now includes the relatively big diff,
but having the file go from two thousand lines to four thousand lines
seems reasonable enough, and keeps the test script simple.

I intended to do this as part of the previous commit,
but clearly forgot to do this last piece.
@mvdan mvdan requested review from myitcv and rogpeppe March 22, 2023 18:27
@mvdan
Copy link
Copy Markdown
Collaborator Author

mvdan commented Mar 22, 2023

CC @thepudds

Copy link
Copy Markdown
Collaborator

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mvdan mvdan merged commit 00e5e28 into rogpeppe:master Mar 22, 2023
@mvdan mvdan deleted the big-diff branch March 27, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants