testscript: remove "large files differ" diff size limit#206
Merged
mvdan merged 1 commit intorogpeppe:masterfrom Mar 22, 2023
Merged
testscript: remove "large files differ" diff size limit#206mvdan merged 1 commit intorogpeppe:masterfrom
mvdan merged 1 commit intorogpeppe:masterfrom
Conversation
Now that we no longer have to worry about pkg/diff's quadratic space memory usage, we can remove this limitation. Note that big_diff now includes the relatively big diff, but having the file go from two thousand lines to four thousand lines seems reasonable enough, and keeps the test script simple. I intended to do this as part of the previous commit, but clearly forgot to do this last piece.
Collaborator
Author
|
CC @thepudds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit message)