robustio: add package#203
Conversation
Taken from x/tools as of 268cb0b82f51be725f8ec432c155a92075cd54c6.
|
Historically we've only copied packages from Go's main repository, not x/tools, so I would lean towards including https://pkg.go.dev/cmd/go/internal/robustio instead of https://pkg.go.dev/golang.org/x/tools/internal/robustio. Also note that the x/tools API is slightly larger, with https://pkg.go.dev/golang.org/x/tools/internal/robustio#GetFileID. I would argue that not including that is a good thing, as it seems like an opaque and low level API that doesn't seem useful on its own. |
mvdan
left a comment
mvdan
left a comment
There was a problem hiding this comment.
Marking as "changes requested" to remind myself :)
3 participants
This adds the
robustiopackage from golang.org/x/tools/internal/robustio which in turn is copied fromcmd/go/internal/robustio.It would be great to add this to go-internal as we've sort of been standardizing on this repo for a lot of go-internal utility packages. I could of course maintain this myself but I hope you consider it for inclusion. The errors it "fixes" (papers over) are quite common when dealing with temporary files on Windows.