gotooltest: run probe commands in temporary directory#188
Merged
Conversation
myitcv
force-pushed
the
gotooltest_temp_dir
branch
from
4b5f683 to
a106d76
Compare
mvdan
approved these changes
Nov 21, 2022
mvdan
reviewed
Nov 21, 2022
mvdan
reviewed
Nov 21, 2022
This ensures we don't make any assumptions about the caller's working directory, which might contain an invalid go.mod, for example.
myitcv
force-pushed
the
gotooltest_temp_dir
branch
from
a106d76 to
1589a92
Compare
Collaborator
Author
|
@mvdan - changes made. PTAL. |
mvdan
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit message)