Use 0o prefix for octal literals, and gofumpt all files#180
Merged
mvdan merged 1 commit intorogpeppe:masterfrom Aug 22, 2022
Merged
Use 0o prefix for octal literals, and gofumpt all files#180mvdan merged 1 commit intorogpeppe:masterfrom
gofumpt all files#180mvdan merged 1 commit intorogpeppe:masterfrom
Conversation
mvdan
approved these changes
Aug 20, 2022
Collaborator
mvdan
left a comment
mvdan
left a comment
There was a problem hiding this comment.
Goes without saying that I like these changes, but perhaps that isn't a proper approval 😉
Collaborator
|
This feels low risk, so I'll go ahead and merge. @rogpeppe can always send a follow-up PR or a revert if he disagrees. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Go 1.13, octal literals can be written using an
0oprefix, instead of the (slightly) ambiguous0. Indeed,gofumptinsists on this, and those of us who usegoplswithgofumptenabled have our octal literals rewritten for us automatically.This commit applies that change, along with some other minor
gofumpt-age, including adding or removing blank lines and reformatting doc comments.