testscript: trim '.txtar' extension from subtest name#179
Merged
mvdan merged 1 commit intorogpeppe:masterfrom Aug 20, 2022
Merged
testscript: trim '.txtar' extension from subtest name#179mvdan merged 1 commit intorogpeppe:masterfrom
mvdan merged 1 commit intorogpeppe:masterfrom
Conversation
bitfield
changed the title
mvdan
approved these changes
Aug 20, 2022
Collaborator
mvdan
left a comment
mvdan
left a comment
There was a problem hiding this comment.
Nicely spotted; I must have missed this when I added support for txtar filename extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that, while the
.txtextension is stripped from the script filename when constructing the subtest name passed tot.Run, the same is not done for scripts with a.txtarextension. This commit strips.txtartoo.Rather than add an explicit test for this, I changed the name of one of the existing test scripts from
.txtto.txtar, so that the tests would fail unless the extension is correctly stripped.