testscript: remove leading newline before results#177
Merged
mvdan merged 1 commit intorogpeppe:masterfrom Aug 22, 2022
Merged
Conversation
mvdan
approved these changes
Aug 22, 2022
Collaborator
mvdan
left a comment
There was a problem hiding this comment.
I imagine the reason was to prevent joining PASS or FAIL with the previous line, i.e. without a newline separating them.
But we don't have any tests that break due to this change, and the only two that change do so in a very reasonable way, so... SGTM :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike
go test, thetestscriptcommand prints a blank line before either 'PASS' or 'FAIL' and its other output:This makes it awkward to use in a loop over many scripts, one at a time. For example:
The desired output is:
But instead, with this leading newline, we see:
This commit removes the newline.