cmd/testscript: allow -e flag to pass env value#122
Merged
Conversation
myitcv
force-pushed
the
allow_env_var_values
branch
2 times, most recently
from
ce7213b to
b38072b
Compare
rogpeppe
approved these changes
Jan 19, 2021
Owner
rogpeppe
left a comment
rogpeppe
left a comment
There was a problem hiding this comment.
LGTM with a couple of minor suggestions, thanks!
The -e flag for testscript currently allows the caller to specify that
environment variables are inherited from the current environment.
However this falls when the current environment does not have a value
set and you need to set a specific value. For example:
GOBUILD=$(go env GOBUILD) testscript -e GOBUILD script.txt
Instead, allow -e to also specify a value:
testscript -e GOBUILD=$(go env GOBUILD) script.txt
which feels more fluent/natural.
myitcv
force-pushed
the
allow_env_var_values
branch
from
b38072b to
587957a
Compare
This was referenced Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -e flag for testscript currently allows the caller to specify that
environment variables are inherited from the current environment.
However this falls when the current environment does not have a value
set and you need to set a specific value. For example:
Instead, allow -e to also specify a value:
which feels more fluent/natural.