fix: reduce Obsidian review warnings#98
Merged
Merged
Conversation
rogerdigital
marked this pull request as ready for review
July 25, 2026 12:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint-plugin-obsidianmdto 0.4.1 and enforce zero-warning lint checksobsidianmd/no-nodejs-modulesrule nameRoot cause
The repository was using an older review-rule package and an obsolete CLI override. The plugin UI also used APIs now flagged by the current recommended rules, and its settings were not indexed by the Obsidian 1.13 settings search.
Impact
Plugin source now passes the current recommended Obsidian rules with zero warnings. A full-repository scan without the intentional Node CLI exceptions reports only the seven expected CLI runtime warnings. Existing Obsidian versions continue to use
display(), while Obsidian 1.13+ receives searchable declarative definitions generated from the same setting specification.Validation
npm run lintnpm run lint:obsidian-warningsnpm run buildnpm test— 198 tests passednpm pack --dry-runnpm audit --omit=dev— 0 vulnerabilities