Skip to content

fix: reduce Obsidian review warnings#98

Merged
rogerdigital merged 1 commit into
mainfrom
fix/scorecard-review-warnings
Jul 25, 2026
Merged

fix: reduce Obsidian review warnings#98
rogerdigital merged 1 commit into
mainfrom
fix/scorecard-review-warnings

Conversation

@rogerdigital

Copy link
Copy Markdown
Owner

Summary

  • upgrade eslint-plugin-obsidianmd to 0.4.1 and enforce zero-warning lint checks
  • replace review-flagged DOM helpers and remove deprecated slider tooltip calls
  • add dual-support declarative setting definitions for Obsidian 1.13+ while retaining the existing settings UI for older supported versions
  • update the CLI rule override to the current obsidianmd/no-nodejs-modules rule name

Root cause

The repository was using an older review-rule package and an obsolete CLI override. The plugin UI also used APIs now flagged by the current recommended rules, and its settings were not indexed by the Obsidian 1.13 settings search.

Impact

Plugin source now passes the current recommended Obsidian rules with zero warnings. A full-repository scan without the intentional Node CLI exceptions reports only the seven expected CLI runtime warnings. Existing Obsidian versions continue to use display(), while Obsidian 1.13+ receives searchable declarative definitions generated from the same setting specification.

Validation

  • npm run lint
  • npm run lint:obsidian-warnings
  • npm run build
  • npm test — 198 tests passed
  • npm pack --dry-run
  • npm audit --omit=dev — 0 vulnerabilities
  • plugin reload in Obsidian 1.12.7

@rogerdigital
rogerdigital marked this pull request as ready for review July 25, 2026 12:02
@rogerdigital
rogerdigital merged commit 5d2e0f7 into main Jul 25, 2026
1 check passed
@rogerdigital
rogerdigital deleted the fix/scorecard-review-warnings branch July 25, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant