Skip to content

fix(report): align counts with active filters#96

Merged
rogerdigital merged 1 commit into
mainfrom
fix/report-filter-counts
Jul 23, 2026
Merged

fix(report): align counts with active filters#96
rogerdigital merged 1 commit into
mainfrom
fix/report-filter-counts

Conversation

@rogerdigital

Copy link
Copy Markdown
Owner

Summary

  • derive report summary totals from the currently visible issues
  • compute scanner facet counts against the active severity filter
  • compute severity facet counts against the active scanner filter
  • keep an active zero-count severity visible so users can clear or change it
  • add model and UI regression coverage for combined filters

Root cause

The report rendered its issue list using active filters but calculated summary and facet counts from the full scan result. This made the displayed totals disagree with the visible results and could hide the active filter needed to recover from a zero-result combination.

Impact

Summary totals and scanner/severity counts now remain consistent with the current filter combination, including zero-result states.

Fixes #93

Validation

  • npm run lint
  • npm run lint:obsidian-warnings
  • npm run build
  • npm test — 20 test files, 166 tests
  • npm pack --dry-run
  • manual UI verification in Obsidian 1.12.7 using /Users/Roger/my-vault: the combined Error + Duplicate Files filter showed zero totals, then clearing Error retained Duplicate Files and restored its scoped counts
  • verified the developer console contained no plugin errors

@rogerdigital
rogerdigital marked this pull request as ready for review July 23, 2026 15:13
@rogerdigital
rogerdigital merged commit 78fed2f into main Jul 23, 2026
1 check passed
@rogerdigital
rogerdigital deleted the fix/report-filter-counts branch July 23, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated files logs with error level are not displayed

1 participant