docs: correct #85 assessment#89
Merged
Merged
Conversation
The CLI relocation to cli/ was expected to hide Node-API usage from the Obsidian community review bot. Post-0.4.13 scorecard check shows all 7 Node-API warnings remain (now flagged at cli/cli.ts instead of src/cli/cli.ts). The bot scans the entire repo, not just src/**. Update the restore-cli plan annotation and tasks/lessons.md to reflect the true outcome: the move did not clear any warnings, its only benefit was cleaner source organization and lint config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the record on #85 after verifying the 0.4.13 scorecard.
The CLI relocation (src/cli/ to cli/) was expected to hide Node-API usage from the Obsidian community review bot. Post-0.4.13 scorecard shows all 7 Node-API warnings remain — the bot scans the whole repo (/*.ts), not just src/. The warnings just moved from src/cli/cli.ts to cli/cli.ts.
Changes:
6/10 + Satisfactory + Health: Excellent is the current architecture ceiling without splitting the CLI into a separate repo. Not pursuing that — cost outweighs the score.